Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smc checks #387

Merged
merged 10 commits into from
Apr 18, 2024
Merged

Smc checks #387

merged 10 commits into from
Apr 18, 2024

Conversation

joelrebel
Copy link
Member

What does this PR implement/change/remove?

  • list x12spo-ntf as supported.
  • Ensure session is closed on a partial Open() failure.

Checklist

  • Tests added
  • Similar commits squashed

The HW vendor this change applies to (if applicable)

SMC

This prevents the client from assumptions that the client has an active
session available
This is to ensure the code within this provider only executes on dells
This is to ensure the Openbmc provider executes code only on hardware
identified to be Openbmc
DoctorVin
DoctorVin previously approved these changes Apr 17, 2024
Copy link
Collaborator

@DoctorVin DoctorVin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update golangci-lint?

@joelrebel
Copy link
Member Author

Need to update golangci-lint?

yep, I'd prefer to do that in a follow up PR.

@joelrebel joelrebel merged commit 5b1e472 into main Apr 18, 2024
5 checks passed
@joelrebel joelrebel deleted the smc-checks branch April 18, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants